Skip to content

[ENH] V1 → V2 API Migration - setups #1619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
EmanAbdelhaleem wants to merge 77 commits into
base: main
Choose a base branch
from
Open

[ENH] V1 → V2 API Migration - setups #1619

EmanAbdelhaleem wants to merge 77 commits into from

Conversation

@EmanAbdelhaleem
Copy link
Contributor

@EmanAbdelhaleem EmanAbdelhaleem commented Jan 20, 2026 •
edited
Loading

Fixes #1625
Depends on #1576
Related to #1575

Details
This PR implements Setups resource, and refactor its existing functions

@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 64.91885% with 281 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.46%. Comparing base (d421b9e) to head (a2e2361).

Files with missing lines Patch % Lines
openml/_api/clients/http.py 53.19% 88 Missing ⚠️
openml/_api/resources/base/versions.py 24.71% 67 Missing ⚠️
openml/_api/setup/backend.py 65.16% 31 Missing ⚠️
openml/_api/resources/base/fallback.py 26.31% 28 Missing ⚠️
openml/testing.py 51.11% 22 Missing ⚠️
openml/_api/resources/setup.py 79.45% 15 Missing ⚠️
openml/_api/setup/_utils.py 56.00% 11 Missing ⚠️
openml/_api/setup/builder.py 81.08% 7 Missing ⚠️
openml/setups/setup.py 33.33% 6 Missing ⚠️
openml/_api/resources/base/base.py 78.57% 3 Missing ⚠️
... and 2 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1619      +/-   ##
==========================================
+ Coverage   52.04%   54.46%   +2.42%     
==========================================
  Files          36       63      +27     
  Lines        4333     5064     +731     
==========================================
+ Hits         2255     2758     +503     
- Misses       2078     2306     +228

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@geetu040 geetu040 mentioned this pull request Jan 21, 2026
Open
25 tasks
@EmanAbdelhaleem EmanAbdelhaleem marked this pull request as ready for review January 21, 2026 23:13
@EmanAbdelhaleem
Copy link
Contributor Author

EmanAbdelhaleem commented Feb 3, 2026

Running the tests for both files:
tests\test_api\test_setups.py or tests\test_setups\test_setup_functions.py give
openml.exceptions.OpenMLServerException: https://www.openml.org/api/v1/xml/setup/exists/ returned code 103: Authen... for setup_exists related tests.

To reproduce:
pytest tests\test_setups\test_setup_functions.py

@EmanAbdelhaleem
Copy link
Contributor Author

EmanAbdelhaleem commented Feb 3, 2026

@geetu040 Ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@geetu040 geetu040 geetu040 requested changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@EmanAbdelhaleem EmanAbdelhaleem

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[ENH] V1 → V2 API Migration - setups

5 participants

@EmanAbdelhaleem @codecov-commenter @geetu040 @fkiraly @SimonBlanke